Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate mono-repo dependency versions to use yarn workspace syntax #23572

Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 24, 2023

Closes N/A

What I did

  • Migrated mono-repo dependency versions to use yarn workspace syntax

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

This pull request has been released as version 7.2.0-canary-23572-1690275421-726e1551.0. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 7.2.0-canary-23572-1690275421-726e1551.0
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/migrate-version-to-use-workspace-syntax
Commit 726e1551
Datetime Tue Jul 25 08:57:01 UTC 2023 (1690275421)
Workflow run 5654725742

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23572

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Jul 24, 2023
@valentinpalkovic valentinpalkovic self-assigned this Jul 24, 2023
@valentinpalkovic valentinpalkovic added ci:normal ci: do not merge patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 24, 2023
@valentinpalkovic valentinpalkovic changed the title Migrate mono-repo dependency versions to use yarn workspace syntax Build: Migrate mono-repo dependency versions to use yarn workspace syntax Jul 24, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/migrate-version-to-use-workspace-syntax branch from e774bc0 to a481660 Compare July 24, 2023 09:23
@ndelangen
Copy link
Member

Let's discuss today @valentinpalkovic

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn npm publish would call internally yarn pack. So this would be a win. Unfortuately, it doesn't support the same CLI arguments then npm publish. Therefore first yarn pack is called to create a package.tgz per package, and with npm publish package.tgz this package is taken to publish to npm. Therefore, npm isn't responsible anymore to build the package. It only takes the tarball archive and publishes it.

I don't really follow this. If yarn npm publish already runs yarn pack, why do you want to run npm publish separately? You say that "it doesn't support the same CLI arguments then npm publish", but as far as I can see you don't supply any other arguments other than the .tgz file, which I would think wouldn't be needed at all if you just used yarn npm publish?
What I'm saying is, isn't yarn pack && npm publish ./package.tgz --tolerate-republish --tag ${tag} the exact same thing as yarn npm publish --tolerate-republish --tag ${tag}?

scripts/release/publish.ts Outdated Show resolved Hide resolved
@valentinpalkovic
Copy link
Contributor Author

You're right! For the actual release, we might be able to switch to yarn npm publish. But I was referencing this code https://github.com/storybookjs/storybook/pull/23572/files#diff-f350f808916daeed26ed59e8d3d6be02aff71db58dd04ce8dcda9ae280dbb537L73-R73. So for verdaccio it seemed to be complicated to switch to yarn npm publish. I tried it, but already setting up the Verdaccio registry seemed to not be worth to switch to yarn npm publish.

@JReinhold
Copy link
Contributor

You're right! For the actual release, we might be able to switch to yarn npm publish. But I was referencing this code #23572 (files). So for verdaccio it seemed to be complicated to switch to yarn npm publish. I tried it, but already setting up the Verdaccio registry seemed to not be worth to switch to yarn npm publish.

Oh I see what you mean. Yeah all of this makes sense to me.

@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Jul 25, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/migrate-version-to-use-workspace-syntax branch from 54934ae to 33efd3d Compare July 26, 2023 12:55
@valentinpalkovic valentinpalkovic merged commit 39b9548 into next Jul 27, 2023
15 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/migrate-version-to-use-workspace-syntax branch July 27, 2023 08:08
This was referenced Jul 27, 2023
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
32 tasks
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Fails
🚫

PR is not labeled with one of: ["patch:no","patch:yes"]

Generated by 🚫 dangerJS against 33efd3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants