Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Defer version bumping to the publish step - Cherry picking #23393 #23421

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

JReinhold
Copy link
Contributor

What I did

This PR manually cherry-picks #23393 back tomain so it has an immediate effect. It looked to be working on next, as the prerelease PR only has deferred version bumps: https://github.com/storybookjs/storybook/pull/23414/files#diff-af9b72cb6dcf333969863361a126e03c67fb19ec94a062462e4d4bc3e2f801cb 💪

(this also re-adds CONTRIBUTING/RELEASING.md, I'm not sure why that was ever deleted on main)

Release tooling: Defer version bumping to the publish step

(cherry picked from commit a930066)

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Release tooling: Defer version bumping to the publish step

(cherry picked from commit a930066)
@JReinhold JReinhold self-assigned this Jul 12, 2023
@JReinhold JReinhold requested a review from shilman July 12, 2023 08:49
@JReinhold JReinhold added build Internal-facing build tooling & test updates patch:no labels Jul 12, 2023
@JReinhold JReinhold merged commit b791562 into main Jul 12, 2023
@JReinhold JReinhold deleted the cherry-pick-deferred-versioning branch July 12, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants