Angular: Enable prod mode when Storybook is built #23404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
ci:daily
valentinpalkovic
changed the title
ndelangen
approved these changes
Jul 11, 2023
valentinpalkovic
added
the
patch:yes
9 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
Merged
27 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
10 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…mode Angular: Enable prod mode when Storybook is built (cherry picked from commit a46cbb1)
github-actions
bot
added
the
patch:done
|
@valentinpalkovic - does that mean it only builds in prod mode? can this be configurable? Major problem for us. |
5 tasks
|
Not sure if it is related but could it be that this breaks my storybook build and giving me a |
|
As soon as #23489 is released, you will be able to activate/deactivate prod mode manually |
|
Thank you for the quick response! |
I have the same issue |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23272
What I did
Use Angular prod mode when Storybook is built
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]