-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Introduce ci:normal
label
#23335
Conversation
Co-authored-by: Kasper Peulen <[email protected]>
4b5be7e
to
0a58cc6
Compare
e6dac94
to
d1473ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I'd be comfortable if @yannbf reviewed this, I think he did most of the initial work here.
6cba4f6
to
553eedb
Compare
553eedb
to
f306128
Compare
@yannbf Could you also take a look? |
@JReinhold Could you take another look? |
fd8233d
to
bc2114c
Compare
@JReinhold One last review. I think now everything is in place :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
0c11104
to
bbc275f
Compare
@valentinpalkovic I'm guessing this PR is superseded and can be closed? |
ci:normal
label
Closes #23278
What I did
I have introduced the
ci:normal
label, which has to be applied to PRs to trigger a normal CircleCI run with a basic set of sandboxes.How to test
ci:daily
,ci:merged
andci:normal
one after another on this pr and see, whether the appropriate circleci job is started (I think this does not work, since the github action file is take fromnext
instead of this branch)Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]