Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Introduce ci:normal label #23335

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 6, 2023

Closes #23278

What I did

I have introduced the ci:normal label, which has to be applied to PRs to trigger a normal CircleCI run with a basic set of sandboxes.

How to test

  • apply the labels ci:daily, ci:merged and ci:normal one after another on this pr and see, whether the appropriate circleci job is started (I think this does not work, since the github action file is take from next instead of this branch)
  • not applying any of the labels will let Danger.js fail, saying, that one of them has to be applied

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic changed the title Introduce ci:normal label CircleCI: Introduce ci:normal label Jul 6, 2023
@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Jul 6, 2023
Co-authored-by: Kasper Peulen <[email protected]>
@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from 4b5be7e to 0a58cc6 Compare July 6, 2023 10:19
@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from e6dac94 to d1473ec Compare July 6, 2023 10:31
@valentinpalkovic valentinpalkovic added ci:normal ci:merged Run the CI jobs that normally run when merged. ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal ci:merged Run the CI jobs that normally run when merged. ci:daily Run the CI jobs that normally run in the daily job. labels Jul 6, 2023
@valentinpalkovic valentinpalkovic added ci:normal ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal ci:daily Run the CI jobs that normally run in the daily job. labels Jul 6, 2023
@valentinpalkovic valentinpalkovic self-assigned this Jul 7, 2023
@valentinpalkovic valentinpalkovic added ci:normal and removed ci:daily Run the CI jobs that normally run in the daily job. labels Jul 7, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I'd be comfortable if @yannbf reviewed this, I think he did most of the initial work here.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from 6cba4f6 to 553eedb Compare July 10, 2023 09:27
@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from 553eedb to f306128 Compare July 10, 2023 09:30
@valentinpalkovic
Copy link
Contributor Author

@yannbf Could you also take a look?

@valentinpalkovic
Copy link
Contributor Author

@JReinhold Could you take another look?

@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from fd8233d to bc2114c Compare July 11, 2023 13:58
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 11, 2023
@valentinpalkovic
Copy link
Contributor Author

@JReinhold One last review. I think now everything is in place :)

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@valentinpalkovic valentinpalkovic force-pushed the valentin/introduce-ci-normal branch from 0c11104 to bbc275f Compare July 12, 2023 07:30
@ndelangen
Copy link
Member

@valentinpalkovic I'm guessing this PR is superseded and can be closed?

@valentinpalkovic valentinpalkovic merged commit 6f4883c into next Jul 13, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/introduce-ci-normal branch July 13, 2023 08:32
This was referenced Jul 13, 2023
@shilman shilman changed the title CircleCI: Introduce ci:normal label CI: Introduce ci:normal label Jul 13, 2023
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PR CI labels
3 participants