-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tooling: Update docs version files when releasing #23235
Release tooling: Update docs version files when releasing #23235
Conversation
…sions-on-docs-site
verbose?: boolean; | ||
}) => { | ||
const isPrerelease = semver.prerelease(version) !== null; | ||
const filename = isPrerelease ? 'next.json' : 'latest.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that you ensure that this never gets called in any other scenarios? Future release? Canary release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. For now we only support the two release types, so it's hard to come up with how the logic would be if there were other types of releases here.
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
…-doesnt-update-versions-on-docs-site Release tooling: Update docs version files when releasing (cherry picked from commit 35fc07b)
Closes #23000
What I did
write-changelog
script also update https://github.com/storybookjs/storybook/tree/next/docs/versions/next.json or https://github.com/storybookjs/storybook/tree/next/docs/versions/latest.json appropriatelywrite-changelog
scriptmain
when publishing a prerelease, so it gets part of a new docs site deployment. This is not necessary the other way around, (for patch releases) since we don't need https://github.com/storybookjs/storybook/tree/next/docs/versions/latest.json to be up-to-date on thenext
branch.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]