Maintenance: Add working Story Explorer config #23163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Some months ago, @ndelangen reached out about support for Storybook 7 in Story Explorer (my VS Code extension) for potential use in the storybook repo. SB7 support has been broadly functional for some time now, but I just finally pushed through an "official" 1.0 release and am now belatedly circling back on that initial request via this PR.
Happily, best I can tell things pretty much just work, with only one bit of important configuration required in the storybook monorepo. That's the path to the relevant Storybook config dir, since the monorepo happens to contain other Storybook configs (e.g.,
test-storybooks/ember-cli/.storybook/main.js
) that are not actually part of the repo's own Storybook instance but whose existence makes the correct path ambiguous. (Hence this PR.)(A couple minor things that don't work: story sorting and custom sidebar labels. This doesn't affect any other functionality, though.)
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]