Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Add working Story Explorer config #23163

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

joshbolduc
Copy link
Contributor

What I did

Some months ago, @ndelangen reached out about support for Storybook 7 in Story Explorer (my VS Code extension) for potential use in the storybook repo. SB7 support has been broadly functional for some time now, but I just finally pushed through an "official" 1.0 release and am now belatedly circling back on that initial request via this PR.

Happily, best I can tell things pretty much just work, with only one bit of important configuration required in the storybook monorepo. That's the path to the relevant Storybook config dir, since the monorepo happens to contain other Storybook configs (e.g., test-storybooks/ember-cli/.storybook/main.js) that are not actually part of the repo's own Storybook instance but whose existence makes the correct path ambiguous. (Hence this PR.)

storybook-story-explorer

(A couple minor things that don't work: story sorting and custom sidebar labels. This doesn't affect any other functionality, though.)

How to test

  1. Install Story Explorer in VS Code (direct link to marketplace)
  2. Open storybook repo in VS Code
  3. A "stories" panel should appear and allow navigating stories, previewing stories, launching Storybook on-demand, etc.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen changed the title Add working Story Explorer config Maintenance: Add working Story Explorer config Jul 10, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jul 10, 2023
@ndelangen ndelangen merged commit 1362fc5 into storybookjs:next Jul 10, 2023
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants