-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix workflow link in release PR description #23116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. ❤️
JReinhold
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Jun 18, 2023
@shilman changes to release tooling generally always needs the patch label as well, since the patch workflow runs from main. This means that the changes also won't take effect until a patch has been done, unless we do the cherry picking manually. |
12 tasks
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
Merged
18 tasks
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 24, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 26, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 26, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Fix workflow link in release PR description (cherry picked from commit 3fb9ab3)
JReinhold
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jun 27, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Internal-facing build tooling & test updates
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
The current release PR description points to the prerelease PR description regardless of whether the PR is a prerelease or a patch. This fixes it.
How to test
Currently untested.