Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix workflow link in release PR description #23116

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 17, 2023

Closes N/A

What I did

The current release PR description points to the prerelease PR description regardless of whether the PR is a prerelease or a patch. This fixes it.

How to test

Currently untested.

  • Run from CLI?
  • Merge & re-run a patch release?

@shilman shilman added the build Internal-facing build tooling & test updates label Jun 17, 2023
@shilman shilman requested a review from JReinhold June 17, 2023 09:45
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. ❤️

@JReinhold JReinhold added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 18, 2023
@JReinhold
Copy link
Contributor

@shilman changes to release tooling generally always needs the patch label as well, since the patch workflow runs from main. This means that the changes also won't take effect until a patch has been done, unless we do the cherry picking manually.

@JReinhold JReinhold merged commit 3fb9ab3 into next Jun 23, 2023
@JReinhold JReinhold deleted the shilman/fix-release-url branch June 23, 2023 11:01
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
12 tasks
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
18 tasks
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 23, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 24, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 26, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 26, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
JReinhold added a commit that referenced this pull request Jun 27, 2023
Build: Fix workflow link in release PR description
(cherry picked from commit 3fb9ab3)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants