CLI: Skip builder selection for react native #23042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this make sense for this or would there be an "other" or "metro" core builder? |
dannyhw
changed the title
dannyhw
changed the title
dannyhw
changed the title
shilman
approved these changes
Jun 13, 2023
shilman
added
patch:yes
kasperpeulen
added a commit
that referenced
this pull request
Jun 14, 2023
…ilder CLI: Skip builder selection for react native
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…ilder CLI: Skip builder selection for react native (cherry picked from commit 8b9ffc7)
This was referenced Jun 14, 2023
Merged
kasperpeulen
added a commit
that referenced
this pull request
Jun 14, 2023
…ilder CLI: Skip builder selection for react native (cherry picked from commit 8b9ffc7)
JReinhold
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23041
Choosing between webpack and vite is confusing for a react-native user since they don't use either. I just set something so that the project gets created as normal without asking.
What I did
adds fallback to webpack for react native, this doesn't seem to effect anything.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]