Core: Disable esbuild on files imported from node_modules
#23018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
esbuild
over some of our larger imports (e.g.typescript
, imported byreact-docgen-typescript-plugin
) can significantly increase their import time (not totally clear why as they are JS files).I'm not sure why we changed this setting from the default (to not run
esbuild
overnode_modules
) in the first place.What I did
Switched back to the default -- to leave files from
node_modules
untranspiled.How to test
Hopefully should be covered by the daily sandboxes. But it would be very interesting to see how this affects our measured timings.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]