Release: Rework versioning command #22997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
changed the title
kasperpeulen
approved these changes
Jun 9, 2023
Comment on lines
+26
to
+28
| jest.spyOn(console, 'log').mockImplementation(() => {}); | ||
| jest.spyOn(console, 'warn').mockImplementation(() => {}); | ||
| jest.spyOn(console, 'error').mockImplementation(() => {}); |
There was a problem hiding this comment.
.mockImplementation() will do the same, as it uses a void function as default
kasperpeulen
pushed a commit
that referenced
this pull request
Jun 9, 2023
Release: Rework versioning command
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the versioning release script from using a combination of
@yarnpkg/plugin-versionandlerna, to manually updating versions and dependencies in allpackage.json's.The plugin was causing OOM errors in Windows unit tests, and lerna wasn't actually necessary.
This solution is a bit simpler conceptually, although the code is a bit more complex.
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]