Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Fix minor scripts and workflows #22990

Merged
merged 14 commits into from
Jun 8, 2023
Merged

Release: Fix minor scripts and workflows #22990

merged 14 commits into from
Jun 8, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jun 8, 2023

Follow-up to #22959, that fixes a lot of things discovered while looking at the workflow runs.

What I did

  • When looking for changes use --first-parent, so we only consider commits on the actual branch, and not any commits within the feature branches
  • Set maxBatchSize: 50 for the dataloader, so we batch requests to GitHub into 50 commits at a time. Should hopefully decrease the timeout
  • Install code dependencies in the workflows, so we use the local version of lerna.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Jun 8, 2023
@JReinhold JReinhold requested a review from a team as a code owner June 8, 2023 19:47
@JReinhold JReinhold self-assigned this Jun 8, 2023
cleanedData[repo][rest.kind][rest.kind === 'pull' ? rest.pull : rest.commit]
);
},
{ maxBatchSize: 50 }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only difference to this file

@JReinhold
Copy link
Contributor Author

Self-merging to unblock unit tests on next.

@JReinhold JReinhold merged commit 2d5e11a into next Jun 8, 2023
@JReinhold JReinhold deleted the next-debug branch June 8, 2023 21:11
kasperpeulen pushed a commit that referenced this pull request Jun 9, 2023
Release: Fix minor scripts and workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants