-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Simplify migration-guide
#22986
Conversation
|
||
- [Webpack4 support discontinued](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack4-support-discontinued) | ||
- [IE11 support discontinued](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#modern-browser-support) | ||
- [Minimum supported version of node is 16](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#dropped-support-for-node-15-and-below) | ||
- [Babel mode v7 exclusively](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#babel-mode-v7-exclusively) | ||
- [Some community addons might not work yet](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#specific-instructions-for-addon-users) | ||
- Storybook CLI changes: | ||
- [Start and build binaries removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#start-storybook--build-storybook-binaries-removed) | ||
- [`DLL` flags removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#removed-dll-flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this one because it's not a commonly-used feature.
- Storybook CLI changes: | ||
- [Start and build binaries removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#start-storybook--build-storybook-binaries-removed) | ||
- [`DLL` flags removed](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#removed-dll-flags) | ||
- [`use-npm` flag deprecated](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#cli-option---use-npm-deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this one because a deprecation is not a breaking change.
314dd69
to
b1876d3
Compare
b1876d3
to
8b6316b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for addressing the feedback. Appreciate it
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
Docs: Simplify `migration-guide` (cherry picked from commit 28197ea)
What I did
Related to #22863, this PR simplifies the 7.0 migration guide to most effectively highlight significant breaking changes
How to test
simplify-migration-guide-cli
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]