Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Upgrade overlayscrollbars #22948

Merged
merged 5 commits into from
Jun 7, 2023
Merged

UI: Upgrade overlayscrollbars #22948

merged 5 commits into from
Jun 7, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 7, 2023

Closes: #19826

This is a heavy dependency, upgrading might do us some good in less weight, this code is definitely easier to understand.

@ndelangen ndelangen requested a review from a team as a code owner June 7, 2023 07:30
@ndelangen ndelangen self-assigned this Jun 7, 2023
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author abbrev 2.0.0 code/package.json via [email protected]

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
overlayscrollbars-react 🆕 0.5.0 None +1 4.32 MB kingsora
overlayscrollbars ⬆️ 1.13.3...2.2.0 None +0/-0 4.28 MB kingsora

Footnotes

  1. https://docs.socket.dev

@ndelangen ndelangen changed the title Dependencies: update overlayscrollbars Dependencies: upgrade overlayscrollbars Jun 7, 2023
@ndelangen ndelangen merged commit 32d2faf into next Jun 7, 2023
@ndelangen ndelangen deleted the norbert/upgrade-scrollbars-v2 branch June 7, 2023 10:44
@KingSora
Copy link

KingSora commented Jun 7, 2023

@ndelangen thanks for migrating to v2.2.0, this should close #19826.

I would have one question and one suggestion:

  1. Is there a specific reason why you don't use the OverlayScrollbarsComponent directly from the overlayscrollbars-react package?
  2. I would highly suggest to use the defer initialization option to make the performance impact even lower.

@ndelangen
Copy link
Member Author

Is there a specific reason

Nope! Ignorance, I guess.

I would highly suggest to use the defer initialization option

We lazy-load the entire component already, would making it deferred really make a difference then?

@KingSora
Copy link

KingSora commented Jun 7, 2023

We lazy-load the entire component already, would making it deferred really make a difference then?

Lazy loading still initializes the component as soon as the import promise resolves.. with defer I'm using the requestIdleCallback api to delay the initialization to a point where the browser isn't busy anymore.. so it potentially has a positive effect and with lazy loading squeezes the max optimization you can achieve for this kind of libraries

@JReinhold JReinhold changed the title Dependencies: upgrade overlayscrollbars Dependencies: Upgrade overlayscrollbars Jun 9, 2023
@JReinhold JReinhold changed the title Dependencies: Upgrade overlayscrollbars UI: Upgrade overlayscrollbars Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: update OverlayScrollbars to version 2
3 participants