-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Upgrade overlayscrollbars
#22948
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
overlayscrollbars
@ndelangen thanks for migrating to v2.2.0, this should close #19826. I would have one question and one suggestion:
|
Nope! Ignorance, I guess.
We lazy-load the entire component already, would making it deferred really make a difference then? |
Lazy loading still initializes the component as soon as the import promise resolves.. with |
overlayscrollbars
overlayscrollbars
overlayscrollbars
overlayscrollbars
Closes: #19826
This is a heavy dependency, upgrading might do us some good in less weight, this code is definitely easier to understand.