Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-measure: Migrate to strict TS #22402

Merged

Conversation

efrenaragon96
Copy link
Contributor

Part of #22176

What I did

Migrate @storybook/addon-measure to strict TS.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks!

@kasperpeulen kasperpeulen added the maintenance User-facing maintenance tasks label May 31, 2023
@efrenaragon96 efrenaragon96 force-pushed the ts-migrate/addon-measure branch from db50d9d to 838901d Compare June 2, 2023 16:47
@efrenaragon96 efrenaragon96 requested a review from a team as a code owner June 2, 2023 16:47
@efrenaragon96 efrenaragon96 force-pushed the ts-migrate/addon-measure branch from 838901d to 64d7ba3 Compare June 2, 2023 17:10
@efrenaragon96 efrenaragon96 force-pushed the ts-migrate/addon-measure branch from 64d7ba3 to cb6818f Compare June 5, 2023 13:00
@socket-security
Copy link

socket-security bot commented Jun 5, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been removed or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

# Conflicts:
#	code/addons/measure/package.json
#	code/yarn.lock
@kasperpeulen kasperpeulen merged commit 5034d63 into storybookjs:next Jun 7, 2023
@JReinhold JReinhold changed the title Migrate @storybook/addon-measure to strict TS Addon-measure: Migrate to strict TS Jun 9, 2023
@jonniebigodes
Copy link
Contributor

@efrenaragon96 one thing left to address as part of this initiative and the amazing work you did by helping us convert Storybook's packages to allow stricter TypeScript support. If you're ok with it, can you message me on our Discord server (same username) so that I can follow up with you?

Hope you have a fantastic day.

Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants