Migrate @storybook/instrumenter to strict TS

code/lib/instrumenter/src/instrumenter.test.ts

@@ -29,7 +29,7 @@ class HTMLElement {
   }
 }
 
-delete global.location;
+delete (global as Partial<typeof globalThis>).location;
 // @ts-expect-error (global scope type conflicts)
 global.location = { reload: jest.fn() };
 // @ts-expect-error (global scope type conflicts)

code/lib/instrumenter/src/instrumenter.ts

@@ -44,8 +44,8 @@ const isObject = (o: unknown) => Object.prototype.toString.call(o) === '[object
 const isModule = (o: unknown) => Object.prototype.toString.call(o) === '[object Module]';
 const isInstrumentable = (o: unknown) => {
   if (!isObject(o) && !isModule(o)) return false;
-  if (o.constructor === undefined) return true;
-  const proto = o.constructor.prototype;
+  if ((o as object).constructor === undefined) return true;
+  const proto = (o as object).constructor.prototype;
   if (!isObject(proto)) return false;
   if (Object.prototype.hasOwnProperty.call(proto, 'isPrototypeOf') === false) return false;
   return true;
@@ -112,6 +112,10 @@ export class Instrumenter {
       isPlaying?: boolean;
       isDebugging?: boolean;
     }) => {
+      if (!storyId) {
+        return;
+      }
+
       const state = this.getState(storyId);
       this.setState(storyId, {
         ...getInitialState(),
@@ -576,7 +580,7 @@ export class Instrumenter {
       }
 
       const hasPrevious = logItems.some((item) =>
-        [CallStates.DONE, CallStates.ERROR].includes(item.status)
+        ([CallStates.DONE, CallStates.ERROR] as (CallStates | undefined)[]).includes(item.status)
       );
       const controlStates: ControlStates = {
         start: hasPrevious,

code/lib/instrumenter/src/types.ts

@@ -61,7 +61,14 @@ export interface SyncPayload {
 }
 
 export interface State {
-  renderPhase: 'loading' | 'rendering' | 'playing' | 'played' | 'completed' | 'aborted' | 'errored';
+  renderPhase?:
+    | 'loading'
+    | 'rendering'
+    | 'playing'
+    | 'played'
+    | 'completed'
+    | 'aborted'
+    | 'errored';
   isDebugging: boolean;
   isPlaying: boolean;
   isLocked: boolean;
@@ -73,7 +80,7 @@ export interface State {
   ancestors: Call['id'][];
   playUntil?: Call['id'];
   resolvers: Record<Call['id'], Function>;
-  syncTimeout: ReturnType<typeof setTimeout>;
+  syncTimeout?: ReturnType<typeof setTimeout>;
   forwardedException?: Error;
 }
 

code/lib/instrumenter/tsconfig.json

@@ -2,6 +2,6 @@
   "extends": "../../tsconfig.json",
   "include": ["src/**/*"],
   "compilerOptions": {
-    "strict": false
+    "strict": true
   }
 }