Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing deprecated tag from JSdoc #21794

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

ndelangen
Copy link
Member

Closes #12759
Closes #21753

Seems this PR: #20154
... was trying to fix this issue, but didn't, as described in #21753

This is a proper fix, making the deprecated tag show up correctly

@ndelangen ndelangen added the bug label Mar 28, 2023
@ndelangen ndelangen self-assigned this Mar 28, 2023
@ndelangen ndelangen requested review from shilman and JReinhold March 28, 2023 12:02
@ndelangen ndelangen changed the title fix https://github.com/storybookjs/storybook/issues/12759 Fix: missing deprecated tag from JSdoc Mar 28, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are failing because of our changes to the structure.

But looks good!

code/lib/docs-tools/src/argTypes/docgen/createPropDef.ts Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit f2f280c into next Mar 28, 2023
@ndelangen ndelangen deleted the norbert/fix-jstag-deprecated-not-showing-up branch March 28, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JSDocs tags are dropped Support @deprecated jsdoc tag
2 participants