Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport: Fix the defaultOrientation config option #21536

Closed
wants to merge 1 commit into from
Closed

Viewport: Fix the defaultOrientation config option #21536

wants to merge 1 commit into from

Conversation

jpzwarte
Copy link
Member

So #21048 was actually broken. This fixes that (tested this time!).

@shilman shilman changed the title Fix the defaultOrientation config option of the viewport addon. Viewport: Fix the defaultOrientation config option Mar 13, 2023
@ndelangen
Copy link
Member

@shilman I think this is actually a good bugfix to merge into 7.0. WDYT?

@jpzwarte jpzwarte closed this by deleting the head repository Mar 14, 2023
@ndelangen
Copy link
Member

@jpzwarte did you intend to delete the branch (which auto-closes PRs)?

@jpzwarte
Copy link
Member Author

NO :(

@jpzwarte jpzwarte reopened this Mar 15, 2023
@jpzwarte
Copy link
Member Author

I removed my local fork, which caused this PR to be closed :( Was not my intention.

@valentinpalkovic
Copy link
Contributor

@ndelangen Can we merge this one?

@ndelangen
Copy link
Member

I can't update this @jpzwarte

(next) % git remote add jpzwarte [email protected]:jpzwarte/storybook.git                                                                                                                                                                                                 ~/Projects/Storybook/core
git fetch jpzwarte fix/viewport-orientation
git switch --track jpzwarte/fix/viewport-orientation
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: invalid reference: jpzwarte/fix/viewport-orientation

jpzwarte added a commit that referenced this pull request Apr 6, 2023
@jpzwarte
Restore branch for PR #21536
c1f4580
@jpzwarte jpzwarte mentioned this pull request Apr 6, 2023
Merged
@jpzwarte
Copy link
Member Author

jpzwarte commented Apr 6, 2023

@ndelangen see the new PR: #21962

@jpzwarte jpzwarte closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
addon: viewport bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpzwarte @ndelangen @valentinpalkovic @shilman