Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Require main.js without cache in automigrations #21498

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 9, 2023

Closes #

What I did

Automigrations were failing sometimes because when the first automigration required main.js, it was put into cache, and the subsequent automigration would require a cached version of main.js, without the changes from previous automigrations, leading to errors like:

missing-babelrc:
Cannot read properties of undefined (reading 'name')

How to test

  1. Bootstrap the libs
  2. Go to a SB 6 project
  3. Try to automigrate it
  4. It should be successful. Before, it'd error with the message from above

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug cli core ci:daily Run the CI jobs that normally run in the daily job. labels Mar 9, 2023
@yannbf yannbf requested review from ndelangen and shilman March 9, 2023 07:27
@shilman shilman changed the title CLI: require main.js without cache in automigrations CLI: Require main.js without cache in automigrations Mar 9, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Great job @yannbf

@ndelangen ndelangen merged commit 0d4810b into next Mar 9, 2023
@ndelangen ndelangen deleted the fix/load-main-config-cache branch March 9, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. cli core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants