Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2128 Add platform option for haul bundler #2129

Merged
merged 6 commits into from
Oct 30, 2017
Merged

Conversation

z4o4z
Copy link
Member

@z4o4z z4o4z commented Oct 26, 2017

Issue:
#2128

What I did

Add platform option to storybook-cli;

How to test

storybook start -p 7007 --haul webpack.haul.storybook.js
storybook start -p 7007 --haul webpack.haul.storybook.js --platform ios
storybook start -p 7007 --haul webpack.haul.storybook.js --platform android

Is this testable with jest or storyshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
Yes
If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #2129 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
+ Coverage    21.4%   21.43%   +0.03%     
==========================================
  Files         263      263              
  Lines        5812     5803       -9     
  Branches      694      702       +8     
==========================================
  Hits         1244     1244              
+ Misses       4039     4027      -12     
- Partials      529      532       +3
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 19.54% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5391854...820bf7b. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me. I migrated away from haul recently so I don't have another project to test this.

@z4o4z z4o4z merged commit ef7869d into master Oct 30, 2017
@danielduan danielduan deleted the haul-platform-option branch October 30, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants