-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stable Next.js v13.2.0 next/font #21247
Use stable Next.js v13.2.0 next/font #21247
Conversation
Thank you so much for your contribution! I like what you have done! Though, we have to make the changes less disruptive. I am ok with changing docs and examples immediately from |
Hi @valentinpalkovic . No problem! Last commit should bring |
You forgot to push the |
ci/circleci: check fails, there are some problems with usePathName and useSearchParams from next/navigation after next.js v13.2.x update. Used in Navigation.stories.tsx Related issue: vercel/next.js#46360 |
#21304 Got merged 3 hours ago. Please merge next into your branch one more time :) |
It seems we also have a missing headRenderedAboveThisLevel property in src/routing/app-router-provider.tsx(81,11) |
code/frameworks/nextjs/src/font/webpack/loader/google/get-font-face-declarations.ts
Outdated
Show resolved
Hide resolved
Well done @alex-ahumada! 🎉 |
Thanks @valentinpalkovic ! Great teamwork! 😄 |
I still see the import error when I import Storybook version: 7.0.0-beta.61 Error: |
@Cayan can you provide a reproduction? |
I can create one later today @valentinpalkovic |
Closes #21330
What I did
Migrated @next/font to stable next/font present in next.js v13.2.0.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.