CLI: Improve how automigrations read main.js
#21168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20955
What I did
Followup work from #20647 regarding #20955.
This PR refactors the remaining automigrations to use the improved helpers created in #20647 in order to read
main.js
by evaluating it, instead of parsing its AST, making it possible for any automigration to detect its case in non-standard Storybook configurations, while possibly failing at the write level (if the user runs the migration).How to test
path/to/repo/lib/cli/index.js automigrate
in that projectChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]