Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Allow stories folder to be served by vite sandboxes #21022

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Build: Allow stories folder to be served by vite sandboxes #21022

merged 1 commit into from
Feb 9, 2023
+1 −1

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 9, 2023

The vue2 sandbox uses the stories folder, which needed to be allowed.

What I did

Allowed it.

How to test

Try running vue2-vite/2.7-js sandbox

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Feb 9, 2023
@tmeasday tmeasday requested a review from JReinhold February 9, 2023 02:37
shilman
shilman approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday tmeasday merged commit 7be61cb into next Feb 9, 2023
@tmeasday tmeasday deleted the fix-vue-sandbox branch February 9, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@JReinhold JReinhold Awaiting requested review from JReinhold

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman