-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] new layout-system #2101
[WIP] new layout-system #2101
Conversation
Progress update: This file will be loaded into the manager directly, the preview does not push the options into the manager on first run. (It still can). Something to discuss on the roadmap meeting 🎉 |
4221568
to
fb1336e
Compare
@shilman Can we discuss if this satisfies your idea of what must be done to get this merged into A 3.x release? Anyone else on the @storybooks/team want to weigh in on that? @danielduan @Hypnosphi ? |
I'm definitely leaning towards having this be 3.4. This does change Storybook's behavior for every possible user we have so it's definitely not a minor refactor. However, if we can get this completed soon and go through a good amount of alpha testing, I could be convinced that this be included in 3.3. |
Definitely 3.4 or higher, 3.3 is locked for significant changes AFAIK. |
Hi, I was wondering if this is still being worked on (maybe in another PR)? We wanted to customize the layout and styling for the storybook UI itself but as mentioned earlier in this issue, that's not currently possible due to the dynamically generated nature of the CSS classes. I wouldn't mind helping out in this regard and opening a PR but wanted to make sure noone else is already working on this. |
Work In Progress
New layout system:
This introduced a new core principle for storybook called 'layout'.
This can be set via a
config.js
or perhaps in the future could be set per story basis.goals:
stretch goals
long stretch goals