Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Hash error messages #20990

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Telemetry: Hash error messages #20990

merged 1 commit into from
Feb 8, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 7, 2023

What I did

One way hash of error messages to preserve privacy

How to test

# add an error to main.js
STORYBOOK_TELEMETRY_DEBUG=1 yarn storybook

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Feb 7, 2023
@shilman shilman requested a review from tmeasday February 8, 2023 03:24
tmeasday
tmeasday approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman marked this pull request as ready for review February 8, 2023 12:37
@shilman shilman merged commit 742f878 into next Feb 8, 2023
@shilman shilman deleted the shilman/hash-error-message branch February 8, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday