Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: add a default background to newly initialized storybooks #20982

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Tech: add a default background to newly initialized storybooks #20982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb57803
add a default background to newly initialized storybooks
ndelangen Feb 7, 2023
30816d0
fix snapshots
ndelangen Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions code/lib/cli/src/generators/configure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ describe('configurePreview', () => {
expect(previewConfigPath).toEqual('./.storybook/preview.js');
expect(previewConfigContent).toMatchInlineSnapshot(`
"export const parameters = {
backgrounds: {
default: 'light',
},
actions: { argTypesRegex: \\"^on[A-Z].*\\" },
controls: {
matchers: {
Expand All @@ -108,6 +111,9 @@ describe('configurePreview', () => {
expect(previewConfigPath).toEqual('./.storybook/preview.ts');
expect(previewConfigContent).toMatchInlineSnapshot(`
"export const parameters = {
backgrounds: {
default: 'light',
},
actions: { argTypesRegex: \\"^on[A-Z].*\\" },
controls: {
matchers: {
Expand Down Expand Up @@ -150,6 +156,9 @@ describe('configurePreview', () => {
import docJson from \\"../documentation.json\\";
setCompodocJson(docJson);
export const parameters = {
backgrounds: {
default: 'light',
},
actions: { argTypesRegex: \\"^on[A-Z].*\\" },
controls: {
matchers: {
Expand Down
3 changes: 3 additions & 0 deletions code/lib/cli/src/generators/configure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ export async function configurePreview(options: ConfigurePreviewOptions) {
const preview = dedent`
${prefix}
export const parameters = {
backgrounds: {
default: 'light',
},
actions: { argTypesRegex: "^on[A-Z].*" },
controls: {
matchers: {
Expand Down