Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Change rootDir in TS plugin #20911

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Build: Change rootDir in TS plugin #20911

merged 1 commit into from
Feb 3, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 2, 2023

Issue: TS not working for our own project

What I did

Correct the root path passed to the plugin. Although viteConfig.root is incorrect, the vite build appears to use the correct paths so I didn't actually change the value passed to vite (should I?)

How to test

Make a small change in a PR-- see

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday added bug build Internal-facing build tooling & test updates labels Feb 2, 2023
@tmeasday tmeasday requested review from IanVS and ethriel3695 February 2, 2023 23:55
@tmeasday tmeasday removed the bug label Feb 3, 2023
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. If Vite's building happily then I think this is the correct change.

Copy link
Contributor

@ethriel3695 ethriel3695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmeasday You got it!

Starting partial build
    → Snapshots will be limited to 2 story files affected by recent changes
    → [ *                  ]
✔ TurboSnap enabled
Capturing 10 snapshots and skipping 537 snapshots.

@tmeasday tmeasday merged commit 4ae75c0 into next Feb 3, 2023
@tmeasday tmeasday deleted the fix-ui-turbosnap branch February 3, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants