Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech: improve treeshaking - add dist stats file (for comparison) #20908

Merged
merged 18 commits into from
Feb 15, 2023
Merged

Tech: improve treeshaking - add dist stats file (for comparison) #20908

merged 18 commits into from
Feb 15, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 2, 2023 •
edited
Loading

  • Update the bundle script to do more tree-shaking
  • Don't generate .mjs-files for code that runs exclusively in node (sometime in 8.0 we'll revisit this when we go ESM-only)
  • Update the dist-size stats file, to show effects of the bundler change

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Feb 3, 2023
@ndelangen ndelangen self-assigned this Feb 3, 2023
@ndelangen ndelangen mentioned this pull request Feb 3, 2023
Closed
@ndelangen ndelangen changed the title Debug: dist size comparison baseline Tech: improve treeshaking - add dist stats file (for comparison) Feb 3, 2023
@ndelangen ndelangen marked this pull request as ready for review February 4, 2023 12:36
@ndelangen ndelangen changed the base branch from next to norbert/bench-dist-stats February 6, 2023 09:21
@ndelangen ndelangen mentioned this pull request Feb 6, 2023
Closed
@ndelangen ndelangen requested a review from shilman February 6, 2023 09:50
@storybookjs storybookjs deleted a comment from socket-security bot Feb 15, 2023
@ndelangen ndelangen merged commit c7bdbf1 into norbert/bench-dist-stats Feb 15, 2023
@ndelangen ndelangen deleted the norbert/stats-analysis-baseline branch February 15, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic left review comments

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @valentinpalkovic