Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: only add dependencies on sb init if they do not exist #20811

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 27, 2023

Issue: N/A

What I did

When running sb init -f and no dependencies are required to be installed (because they already exist in package.json), it would crash in pnpm:

image

This PR fixes that, making sure that the "add dependencies" step only runs if needed

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen merged commit dbe8f12 into next Jan 30, 2023
@ndelangen ndelangen deleted the fix/init-when-no-deps-are-needed branch January 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants