Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve storyIndexers & makeTitle documentation #20810

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

sheriffMoose
Copy link
Contributor

What I did

  • added more documentation for storyIndexers & makeTitle

How to test

  • CI Passes

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheriffMoose thank you very much for this fantastic pull request and for helping us improve the documentation. We appreciate it 🙏 . I left some items that require your attention. When you have a chance, can you take a look at the changes and apply them? If you have any questions, please do reach out so that we can merge this pull request.

Hope you have a great day.

Stay safe

docs/configure/sidebar-and-urls.md Outdated Show resolved Hide resolved
docs/configure/sidebar-and-urls.md Outdated Show resolved Hide resolved
docs/snippets/common/csf-3-example-title.mdx.mdx Outdated Show resolved Hide resolved
@sheriffMoose sheriffMoose reopened this Feb 3, 2023
@sheriffMoose
Copy link
Contributor Author

@jonniebigodes had to discard my commits then cherry-pick them again to avoid the huge rebase
made all the changes you suggested, thanks for the feedback

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheriffMoose, thanks for addressing the feedback and your willingness to continue working on this pull request, despite some additional work required. Appreciate it. I left one item I would like you to look at so we can merge this.

Also, no need to thank you whatsoever. It's my pleasure to guide you through the documentation process.

Let me know, and we'll go from there.

Hope you have a great day.

Stay safe

docs/configure/sidebar-and-urls.md Outdated Show resolved Hide resolved
@jonniebigodes
Copy link
Contributor

@sheriffMoose, thanks for addressing the feedback so promptly. Appreciate it 🙏 ! I took a last look, and we're in the green. Going to merge this one.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes merged commit 8d9d279 into storybookjs:next Feb 14, 2023
@sheriffMoose sheriffMoose deleted the docs/makeTitle branch February 14, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants