-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve storyIndexers & makeTitle documentation #20810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheriffMoose thank you very much for this fantastic pull request and for helping us improve the documentation. We appreciate it 🙏 . I left some items that require your attention. When you have a chance, can you take a look at the changes and apply them? If you have any questions, please do reach out so that we can merge this pull request.
Hope you have a great day.
Stay safe
e07d872
to
904dba3
Compare
@jonniebigodes had to discard my commits then cherry-pick them again to avoid the huge rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheriffMoose, thanks for addressing the feedback and your willingness to continue working on this pull request, despite some additional work required. Appreciate it. I left one item I would like you to look at so we can merge this.
Also, no need to thank you whatsoever. It's my pleasure to guide you through the documentation process.
Let me know, and we'll go from there.
Hope you have a great day.
Stay safe
@sheriffMoose, thanks for addressing the feedback so promptly. Appreciate it 🙏 ! I took a last look, and we're in the green. Going to merge this one. Hope you have a fantastic day. Stay safe |
What I did
storyIndexers
&makeTitle
How to test