-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change forceReRender story to forceRemount #20752
Conversation
@tmeasday this was naive of me. emitting
|
I don't think we should do anything fundamental to make the story work (if that's what you were suggesting in 2. But can we do something a little hackier? Like only run the play function once per second or something like that? I'm not sure if the story remounting is going to cause a problem for chromatic anyway perhaps, but at least this way we could test it manually (i.e we might need to disable chromatic). |
@tmeasday I've been through every single published Storybook now, and they all work as expected: alternating between focus and blur every 3 seconds. The story is disabled in both Chromatic and the test runner. I think we should just merge this in and solve the Chromatic issue separately when we feel that is a priority. |
What I did
We have an internal CI story that tests that components remount when forced to - by asserting that a button looses focus after the event. However it was actually emitting
FORCE_RE_RENDER
, while actually it is theFORCE_REMOUNT
that should trigger that behavior. Which is why I've changed it.I've also enabled Vue for the tests, as that use case was recently fixed by #20712
How to test
See all sandboxes in Chromatic should actually be correct now.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]