Blocks: New Canvas API #20723
Merged
Blocks: New Canvas API #20723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torybookjs/storybook into jeppe/sb-1145-update-api-of-canvas-block
…-1145-update-api-of-canvas-block
…-1145-update-api-of-canvas-block
…-1145-update-api-of-canvas-block
JReinhold
commented
Jan 22, 2023
JReinhold
commented
Jan 22, 2023
JReinhold
commented
Jan 22, 2023
tmeasday
reviewed
Jan 23, 2023
tmeasday
approved these changes
Jan 24, 2023
Comment on lines
+129
to
+134
| Children.forEach(children, (child) => { | ||
| if (layout) { | ||
| return; | ||
| } | ||
| layout = (child as ReactElement)?.props?.parameters?.layout; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| Children.forEach(children, (child) => { | |
| if (layout) { | |
| return; | |
| } | |
| layout = (child as ReactElement)?.props?.parameters?.layout; | |
| }); | |
| const layout ??= | |
| Children.map(children, | |
| (child) => (child as ReactElement)?.props?.parameters?.layout | |
| ).find(Boolean); |
There was a problem hiding this comment.
I'm sorry I have to disagree here.
cleverness++, readability--
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12135
What I did
This PR changes the Canvas block to use the new
ofbased API, while still being backwards compatible with the existing API, that is now deprecated and will be removed in 8.0.It also changes the
DocsStoryblock to use the new API, without being backwards compatible as it is an undocumented component.All that's missing here is the migration docs, but they will be easier to write once #20699 lands.
How to test
See stories in published UI SB:
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]