-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Created ArgTypes
component and stories
#20664
Conversation
This reverts commit 580ee45.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this block need to support the components prop?
Does this block need to support the showComponent prop? If so, should it be a parameter (docs.argTypes.showComponent?)
No, those are both undocumented features and we have discussed internally that we should just remove them entirely.
Does this block need to show the component / subcomponents in a separate tab?
Yes I would think so, we think people use that and we don't have an argument for removing it.
Does what this block does when you do of={meta} make sense?
It behaves as I would expect!
Ok, as discussed offline:
We are going to drop this concept for now ( Both will be supported until 8.0 in the legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Jeppe Reinhold <[email protected]>
….com/storybookjs/storybook into tom/sb-1149-implement-argtypes-block
Issue: N/A
What I did
Created an
ArgTypes
block and stories to test it.Questions:
components
prop?showComponent
prop? If so, should it be a parameter (docs.argTypes.showComponent
?)of={meta}
make sense?How to test
See stories in chromatic / UI SB.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]