Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add Sun, Moon, Sidebyside, and stacked icons #20621

Merged
merged 1 commit into from
Jan 18, 2023
Merged

UI: Add Sun, Moon, Sidebyside, and stacked icons #20621

merged 1 commit into from
Jan 18, 2023

Conversation

MichaelArestad
Copy link
Contributor

Issue: #19884

What I did

  1. Added sun, moon, sidebyside, and stacked icons
  2. Added them to the theme switcher

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@MichaelArestad MichaelArestad self-assigned this Jan 13, 2023
JReinhold
JReinhold approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JReinhold JReinhold added the ui label Jan 18, 2023
@shilman shilman changed the title Added Sun, Moon, Sidebyside, and stacked icons UI: Add Sun, Moon, Sidebyside, and stacked icons Jan 18, 2023
@shilman shilman merged commit 28e34ac into next Jan 18, 2023
@shilman shilman deleted the add-sun-moon-icons branch January 18, 2023 14:04
@shilman shilman mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

@domyen domyen domyen approved these changes

Assignees

@MichaelArestad MichaelArestad

Labels
feature request ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelArestad @domyen @JReinhold @shilman