Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make changes to typings files to ensure this the check command succeeds #20598

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 12, 2023

trying to get the check command to go green on tom's PR

telescoped on #20425

@ndelangen ndelangen self-assigned this Jan 12, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jan 12, 2023
@ndelangen
Copy link
Member Author

ndelangen commented Jan 12, 2023

@kasperpeulen would you have an idea why all this might be needed all of a sudden?

See the CI failures here:
https://app.circleci.com/pipelines/github/storybookjs/storybook/37944/workflows/4d851337-0126-4043-9a38-2d371497aba9/jobs/467028

> nx run @storybook/manager:check

../../lib/manager-api/src/lib/addons.ts(122,15): error TS2551: Property '___STORYBOOK_ADDONS_MANAGER' does not exist on type 'typeof globalThis'. Did you mean '__STORYBOOKADDONS__'?
../../lib/manager-api/src/lib/addons.ts(123,12): error TS2551: Property '___STORYBOOK_ADDONS_MANAGER' does not exist on type 'typeof globalThis'. Did you mean '__STORYBOOKADDONS__'?
../../lib/manager-api/src/lib/addons.ts(125,17): error TS2551: Property '___STORYBOOK_ADDONS_MANAGER' does not exist on type 'typeof globalThis'. Did you mean '__STORYBOOKADDONS__'?
../../lib/manager-api/src/modules/refs.ts(280,50): error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
../../lib/manager-api/src/modules/release-notes.ts(7,9): error TS2339: Property 'RELEASE_NOTES_DATA' does not exist on type 'typeof globalThis'.
../../lib/manager-api/src/modules/versions.ts(10,9): error TS2339: Property 'VERSIONCHECK' does not exist on type 'typeof globalThis'.

... on tom's PR (see here: #20425)

@ndelangen ndelangen requested a review from tmeasday January 12, 2023 18:21
@tmeasday
Copy link
Member

tmeasday commented Jan 12, 2023

It's pretty weird given the set of changes in my PR that triggered this: https://github.com/storybookjs/storybook/pull/20425/files#diff-5f3b461267dd493f3353db09d428b794e60fb594b2695d8c9977c054c005977b -- no changes to any config files and pretty minor type changes.

Are we only type checking these files when there are changes to them or something? (I guess I didn't even touch all these files, but I did make changes to the manager-api package that they are in).

@ndelangen
Copy link
Member Author

I was hoping @kasperpeulen would be able to assist in figuring out what happened 🙏

@yannbf
Copy link
Member

yannbf commented Jan 13, 2023

One of these errors happened on next as well, with an Angular template:

image

@ndelangen
Copy link
Member Author

I'm just going to push this forwards then, to unblock next.

@ndelangen ndelangen merged commit dead68d into tom/sb-1123-sb20250-vite-does-not-show-a-spinner-2 Jan 13, 2023
@ndelangen ndelangen deleted the norbert/make-typescript-check-work-valid branch January 13, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants