Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Count play function usage #20541

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Telemetry: Count play function usage #20541

merged 1 commit into from
Jan 10, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 9, 2023 •
edited
Loading

Issue: N/A

Telescopes on #20539

What I did

  • Add auto-generated play-fn tag to story index
  • Add component-level play function template story
  • Add play functions to index summary

How to test

In a sandbox:

STORYBOOK_TELEMETRY_DEBUG=1 yarn storybook

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Jan 9, 2023
tmeasday
tmeasday approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shilman shilman mentioned this pull request Jan 10, 2023
Merged
4 tasks
@shilman shilman marked this pull request as ready for review January 10, 2023 03:03
Base automatically changed from shilman/add-page-story-counts to next January 10, 2023 05:55
@shilman shilman merged commit e4e6387 into next Jan 10, 2023
@shilman shilman deleted the shilman/detect-play-functions branch January 10, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday