Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: fix InternalCanvas story tests #20521

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Build: fix InternalCanvas story tests #20521

merged 3 commits into from
Jan 6, 2023

Conversation

ndelangen
Copy link
Member

Issue: next is broken

What I did

Ensure we render this story in light theme only
Ensure the play function queries for the right element

@ndelangen ndelangen self-assigned this Jan 6, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jan 6, 2023
@ndelangen ndelangen requested a review from yannbf January 6, 2023 14:51
@yannbf yannbf changed the title fix the play function of this story that was failing in chromatic Build: fix InternalCanvas story tests Jan 6, 2023
yannbf
yannbf approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen @yannbf
fix it!
55a1607 
Co-authored-by: Yann Braga <[email protected]>
@ndelangen ndelangen merged commit af847ba into next Jan 6, 2023
@ndelangen ndelangen deleted the norbert/fix-next branch January 6, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @yannbf