-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding solidjs-vite framework #20435
Conversation
|
||
## Getting Started | ||
|
||
### In a project without Storybook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To automatically setup the solidjs-vite framework and to install it automatically for the user, you have to make some adjustments in https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/project_types.ts#L123 and https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/initiate.ts#L67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentinpalkovic I made changes to the needed files, if there is something else please guide me
@mzaien Thank you for your outstanding contribution! I left some comments. If you have questions, feel free to ask at any time. |
@mzaien I want to give you a quick update: I will discuss your PR internally with the other Storybook maintainers. We'll discuss which criteria must be fulfilled to accept a new Storybook framework in the Storybook Monorepo. Due to the holiday season, I would like to ask you for some patience. I will let you know as soon as we have discussed your PR. Nevertheless, thank you for your incredible work! |
Understood 👍, thanks for your time and guide |
Hello @valentinpalkovic 👋, not wanting to be annoying or something but any updates here (ops 🤣) , |
Hello @ndelangen , |
@mzaien apologies for the delay, I've been dealing with some things on my side. The storybook core team has decided that we need to focus on fixing bugs and get ready for the 7.0 release. We therefore need to constraint a little what we can merge into the repo at this time. #20411 by @literalpie shows an example of this, the CLI makes external references to packages in community packages. |
@mzaien Have you started a standalone project for a solid storybook framework? If it's helpful, I can port some of this code to a new repo |
Nevermind, it looks like https://github.com/storybookjs/solidjs is already started |
@literalpie oh did not know we can make new project under storybook, thanks for enlightening me |
Issue:
maybe this #18583 can be closed
What I did
Implemented Vite builder coupled with Solid renderer using the official
vite-plugin-solid
plugin.How to test
not sure about if this is testable tbh, I followed steps made in this pr to give credit