Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding solidjs-vite framework #20435

Closed
wants to merge 2 commits into from
Closed

feat: adding solidjs-vite framework #20435

wants to merge 2 commits into from

Conversation

mzaien
Copy link

@mzaien mzaien commented Dec 29, 2022

Issue:
maybe this #18583 can be closed

What I did

Implemented Vite builder coupled with Solid renderer using the official vite-plugin-solid plugin.

How to test

  • [ ] Is this testable with Jest or Chromatic screenshots?
  • [ x ] Does this need a new example in the kitchen sink apps?
  • [ x ] Does this need an update to the documentation?

not sure about if this is testable tbh, I followed steps made in this pr to give credit

code/frameworks/solidjs-vite/README.md Outdated Show resolved Hide resolved

## Getting Started

### In a project without Storybook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To automatically setup the solidjs-vite framework and to install it automatically for the user, you have to make some adjustments in https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/project_types.ts#L123 and https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/initiate.ts#L67

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic I made changes to the needed files, if there is something else please guide me

@valentinpalkovic
Copy link
Contributor

@mzaien Thank you for your outstanding contribution! I left some comments. If you have questions, feel free to ask at any time.

code/lib/cli/src/repro-templates.ts Outdated Show resolved Hide resolved
code/lib/cli/src/repro-templates.ts Outdated Show resolved Hide resolved
code/lib/cli/src/repro-generators/configs.ts Outdated Show resolved Hide resolved
code/lib/cli/src/project_types.ts Show resolved Hide resolved
code/lib/cli/src/generators/SOLID/index.ts Outdated Show resolved Hide resolved
code/lib/cli/src/initiate.ts Outdated Show resolved Hide resolved
code/frameworks/solidjs-vite/package.json Show resolved Hide resolved
@valentinpalkovic
Copy link
Contributor

@mzaien I want to give you a quick update: I will discuss your PR internally with the other Storybook maintainers. We'll discuss which criteria must be fulfilled to accept a new Storybook framework in the Storybook Monorepo. Due to the holiday season, I would like to ask you for some patience. I will let you know as soon as we have discussed your PR. Nevertheless, thank you for your incredible work!

@mzaien
Copy link
Author

mzaien commented Dec 30, 2022

@mzaien I want to give you a quick update: I will discuss your PR internally with the other Storybook maintainers. We'll discuss which criteria must be fulfilled to accept a new Storybook framework in the Storybook Monorepo. Due to the holiday season, I would like to ask you for some patience. I will let you know as soon as we have discussed your PR. Nevertheless, thank you for your incredible work!

Understood 👍, thanks for your time and guide

@mzaien
Copy link
Author

mzaien commented Jan 10, 2023

Hello @valentinpalkovic 👋, not wanting to be annoying or something but any updates here (ops 🤣) ,
I'm exited to open a new pr after this to support qwik.js it was done :D #20411

@mzaien
Copy link
Author

mzaien commented Jan 27, 2023

Hello @ndelangen ,
not meaning to bother you do I need to do anything to move forward with this pr 😆 I would love to do anything to have it before storybook 7 release 🚀

@ndelangen
Copy link
Member

@mzaien apologies for the delay, I've been dealing with some things on my side.

The storybook core team has decided that we need to focus on fixing bugs and get ready for the 7.0 release.

We therefore need to constraint a little what we can merge into the repo at this time.
We decided we can extend the storybook CLI to allow for new renderers/frameworks; but we won't be adding those renderers themselves to the repo at this time.

#20411 by @literalpie shows an example of this, the CLI makes external references to packages in community packages.

@literalpie
Copy link
Contributor

@mzaien Have you started a standalone project for a solid storybook framework? If it's helpful, I can port some of this code to a new repo

@literalpie
Copy link
Contributor

Nevermind, it looks like https://github.com/storybookjs/solidjs is already started

@mzaien
Copy link
Author

mzaien commented Feb 5, 2023

Nevermind, it looks like https://github.com/storybookjs/solidjs is already started

@literalpie oh did not know we can make new project under storybook, thanks for enlightening me

@mzaien mzaien closed this by deleting the head repository Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants