Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fix prettydocs CI flakyness #20385

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

ndelangen
Copy link
Member

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen changed the title let prettydocs have it's own cache Build: fix prettydocs CI flakyness Dec 22, 2022
@ndelangen ndelangen self-assigned this Dec 22, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Dec 22, 2022
@ndelangen
Copy link
Member Author

@shilman self-merging this

@kasperpeulen this should fix the inconsistent CI job, I think

@ndelangen ndelangen merged commit 76f2338 into next Dec 22, 2022
@ndelangen ndelangen deleted the norbert/prettydocs-ci-fix branch December 22, 2022 19:36
@@ -637,3 +646,5 @@ workflows:
parallelism: 26
requires:
- build-sandboxes

# VS Code Extension Version: 1.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this line intentional @ndelangen ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no!, how did this happen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here:
#20510

ndelangen added a commit that referenced this pull request Jan 5, 2023
thanks for reporting Yann
#20385 (review)

Co-authored-by: Yann Braga <[email protected]>
@ndelangen ndelangen mentioned this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants