-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: add "missing-babelrc" automigration #20341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
reviewed
Dec 20, 2022
yannbf
commented
Dec 20, 2022
yannbf
force-pushed
the
feat/babelrc-automigration
branch
2 times, most recently
from
January 5, 2023 15:17
e7a35ad
to
600a5ec
Compare
yannbf
commented
Jan 5, 2023
Thanks @yannbf for this PR. I'm also suggesting we change the copy for this doc page: https://github.com/storybookjs/storybook/blob/next/docs/configure/typescript.md
This doesn't seem to apply to v7 anymore (as maybe some other parts in this page). |
yannbf
force-pushed
the
feat/babelrc-automigration
branch
from
January 6, 2023 09:53
4688f87
to
62319c8
Compare
JReinhold
requested changes
Jan 6, 2023
yannbf
force-pushed
the
feat/babelrc-automigration
branch
from
January 9, 2023 09:44
62319c8
to
68c2009
Compare
Good to merge @yannbf ? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20302 #20423
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.