Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: add "missing-babelrc" automigration #20341

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 20, 2022

Issue: #20302 #20423

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ivangabriele
Copy link

ivangabriele commented Jan 6, 2023

Thanks @yannbf for this PR. I'm also suggesting we change the copy for this doc page:

https://github.com/storybookjs/storybook/blob/next/docs/configure/typescript.md

Storybook has built-in TypeScript support, so your TypeScript project should work with zero configuration needed.

This doesn't seem to apply to v7 anymore (as maybe some other parts in this page).

@yannbf yannbf force-pushed the feat/babelrc-automigration branch from 4688f87 to 62319c8 Compare January 6, 2023 09:53
@yannbf yannbf force-pushed the feat/babelrc-automigration branch from 62319c8 to 68c2009 Compare January 9, 2023 09:44
@ndelangen ndelangen self-assigned this Jan 9, 2023
@ndelangen
Copy link
Member

Good to merge @yannbf ?

@yannbf yannbf merged commit cd99f77 into next Jan 13, 2023
@yannbf yannbf deleted the feat/babelrc-automigration branch January 13, 2023 16:43
@shilman shilman mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants