Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon-actions peerdependency in nextjs package.json #20324

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Update addon-actions peerdependency in nextjs package.json #20324

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99f3b30
fix: update addon-actions peerdependency in nextjs package.json
Edo-San Dec 19, 2022
3ddad7d
fix: update code yarn.lock
Edo-San Dec 19, 2022
053790d
Update code/frameworks/nextjs/package.json
valentinpalkovic Dec 19, 2022
5ae1fa9
Merge branch 'next' into pr/20324
shilman Dec 20, 2022
589e93c
Update yarn.lock
shilman Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
},
"peerDependencies": {
"@babel/core": "^7.11.5",
"@storybook/addon-actions": "7.0.0-alpha.43",
"@storybook/addon-actions": "7.0.0-beta.12",
Copy link
Contributor

@valentinpalkovic valentinpalkovic Dec 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a Caret constraint to make the version less strict.

Suggested change
"@storybook/addon-actions": "7.0.0-beta.12",
"@storybook/addon-actions": "^7.0.0-beta.12",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho I'd agree with you, I didn't dare to change it since all the other @storybook dependencies are pointing to that same version :D Is it safe to assume that all those deps should follow the same bumping rules, right? Maybe I should bump them as well in order to avoid recreating the conditions that led to this bug? WDYT?

    "@storybook/core-common": "7.0.0-beta.12",
    "@storybook/node-logger": "7.0.0-beta.12",
    "@storybook/preset-react-webpack": "7.0.0-beta.12",
    "@storybook/preview-api": "7.0.0-beta.12",
    "@storybook/react": "7.0.0-beta.12",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files should be handled by an automation script by @shilman, it seems like it was a hiccup and he's going to update it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automation script is a bit brittle -- it looks for the current version & then increments it. I think what happened is that the original PR was already out of sync and so the automation never incremented it properly. I'll merge this & verify that it gets incremented on next release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the release script to deal with ^ versions also per this PR

"next": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0",
Expand Down
2 changes: 1 addition & 1 deletion code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6791,7 +6791,7 @@ __metadata:
webpack: ^5.65.0
peerDependencies:
"@babel/core": ^7.11.5
"@storybook/addon-actions": 7.0.0-alpha.43
"@storybook/addon-actions": 7.0.0-beta.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@storybook/addon-actions": 7.0.0-beta.12
"@storybook/addon-actions": ^7.0.0-beta.12

next: ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0
react: ^16.8.0 || ^17.0.0 || ^18.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
Expand Down