Angular: Fix isStandaloneComponent check #20295
Merged
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipes and directives can also be standalone
stijnvn
changed the title
yannbf
added
bug
angular
ci:daily
|
@storybookjs/angular could one of you give this a thumbs up? |
valentinpalkovic
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipes and directives can also be standalone
Issue:
When you add a standalone directive or pipe as storybook component, you get the error message from Angular that a standalone component can't be declared in any NgModule.
What I did
Changed the isStandaloneComponent check to allow Directive and Pipe.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.