Support Angular 15.0.4 #20287
Merged
Support Angular 15.0.4 #20287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const webpackOptions = compiler.options; | ||
| const entry = | ||
| typeof webpackOptions.entry === 'function' ? webpackOptions.entry() : webpackOptions.entry; | ||
| compiler.hooks.environment.tap(PLUGIN_NAME, () => { |
There was a problem hiding this comment.
This wrapper is the only addition. The rest of the changes are formatting related.
There was a problem hiding this comment.
The change is also backward compatible. Tested it with Angular 15.0.3. Angular 15.0.4 introduced the issue.
ndelangen
approved these changes
Dec 15, 2022
ndelangen
deleted the
valentin/fix-angular-15.0.4-webpack-require-issue
branch
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Dec 20, 2022
…4-webpack-require-issue Support Angular 15.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Angular changed the manipulation behavior in angular/angular-cli@ccc8e03. The webpack plugin adjusts the webpack entry while preparing the webpack compiler environment . The Storybook plugin overwrites webpack.entry earlier, which caused the issue. Now the timing is adjusted and it will overwrite the webpack.entry output of Angular's
Styles Webpack Plugin.How to test
If your answer is yes to any of these, please make sure to include it in your PR.