Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: generate the exports.ts file in a single pass without exec #20002

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 29, 2022

Change the exports.ts generation to happen in a single pass, and less use of sub-processes.

Switch to use esbuild-register for running pre and post steps of the bundle to support pre-esm packages in there.

@ndelangen ndelangen self-assigned this Nov 29, 2022
@ndelangen ndelangen requested a review from shilman November 29, 2022 10:05
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Nov 29, 2022
@ndelangen ndelangen changed the title Tech/gen-exports-file-single-pass Build: generate the exports.ts file in a single pass without exec Nov 29, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit b36691a into next Nov 29, 2022
@shilman shilman deleted the tech/gen-exports-file-single-pass branch November 29, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants