Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change export-generating script to use exec util over shelljs #19979

Merged
merged 1 commit into from
Nov 28, 2022
Merged

change export-generating script to use exec util over shelljs #19979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion code/ui/manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"react-sizeme": "^3.0.1",
"resolve-from": "^5.0.0",
"semver": "^7.3.7",
"shelljs": "^0.8.5",
"store2": "^2.12.0",
"ts-dedent": "^2.0.0",
"typescript": "^4.9.3"
Expand Down
4 changes: 2 additions & 2 deletions code/ui/manager/scripts/generate-exports-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* eslint-disable no-console */
import fs from 'fs-extra';
import path from 'path';
import shelljs from 'shelljs';
import { dedent } from 'ts-dedent';
import { exec } from '../../../../scripts/utils/exec';

const removeDefault = (input: string) => input !== 'default';

Expand All @@ -28,7 +28,7 @@ const run = async () => {
);

console.log('Linting...');
shelljs.exec(`yarn lint:js:cmd --fix ${location}`, {
await exec(`yarn lint:js:cmd --fix ${location}`, {
cwd: path.join(__dirname, '..', '..', '..'),
});
console.log('Done!');
Expand Down
1 change: 0 additions & 1 deletion code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6598,7 +6598,6 @@ __metadata:
react-sizeme: ^3.0.1
resolve-from: ^5.0.0
semver: ^7.3.7
shelljs: ^0.8.5
store2: ^2.12.0
ts-dedent: ^2.0.0
typescript: ^4.9.3
Expand Down