Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls: Exclude { table: { disable: true } } controls while counting controls for panel title #19877

Merged

Conversation

gitstart
Copy link
Contributor

Issue: #18780

What I did

  • Exclude controls with { table: { disable: true } } config while counting controls for panel title.
  • Correct DisableControl story config

How to test

  • Start a sandbox template (In screenshot react-vite/default-ts with yarn task --task dev --template react-vite/default-ts)
  • Navigate to http://localhost:6006/?path=/story/addons-controls-disable--disable-table
  • Verify that addon-controls tab title should be Controls (1) which is the expected behavior since b has { table: { disable: true } }
  • Navigate to http://localhost:6006/?path=/story/addons-controls-disable--disable-control
  • Verify that there is no control for b prop but it is still visible in panel

@valentinpalkovic
Copy link
Contributor

@gitstart Thank you for your contribution. LGTM!

@valentinpalkovic valentinpalkovic merged commit ddca95b into storybookjs:next Nov 22, 2022
@gitstart
Copy link
Contributor Author

gitstart commented Nov 22, 2022

PR pushed through Gitstart with contributions from @BikashSah999 @raph941 @phunguyenmurcul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants