Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Increase max node memory for jobs #19856

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Build: Increase max node memory for jobs #19856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23bf4fd
Build: Increase max node memory for jobs
IanVS Nov 16, 2022
2ad359f
Try setting node option on job itself
IanVS Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ executors:
docker:
- image: cimg/node:16.17.1
environment:
NODE_OPTIONS: --max_old_space_size=3076
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
sb_node_16_browsers:
parameters:
Expand All @@ -32,7 +32,7 @@ executors:
docker:
- image: cimg/node:16.17.1-browsers
environment:
NODE_OPTIONS: --max_old_space_size=3076
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
sb_playwright:
parameters:
Expand All @@ -45,7 +45,7 @@ executors:
docker:
- image: mcr.microsoft.com/playwright:v1.27.0-focal
environment:
NODE_OPTIONS: --max_old_space_size=3076
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>

orbs:
Expand Down Expand Up @@ -405,6 +405,8 @@ jobs:
executor:
class: medium+
name: sb_node_16_browsers
environment:
NODE_OPTIONS: --max_old_space_size=6144
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this helped, but it failed once without and succeeded twice with it. Might just be coincidence?

steps:
# switched this to the CircleCI helper to get the full git history for TurboSnap
- checkout
Expand Down