Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: convert addon-docs to use ts-up #19790

Merged
merged 15 commits into from
Nov 11, 2022
Merged

Build: convert addon-docs to use ts-up #19790

merged 15 commits into from
Nov 11, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 9, 2022

Related: #18732

What I did

convert addon-docs to be build using ts-up

@ndelangen ndelangen requested a review from shilman November 9, 2022 14:55
@ndelangen ndelangen self-assigned this Nov 9, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Nov 9, 2022
@ndelangen ndelangen requested a review from tmeasday November 9, 2022 17:11
@ndelangen
Copy link
Member Author

ndelangen commented Nov 9, 2022

@tmeasday could you help me out on this one please?

I'm puzzled as to what is causing the e2e tests to fail.. I tried locally, and they passed on my local machine.


I also have no idea what's going on with the ci/circleci: chromatic-internal-storybooks task, which also succeeds on my own machine..

@tmeasday
Copy link
Member

tmeasday commented Nov 9, 2022

I also have no idea what's going on with the ci/circleci: chromatic-internal-storybooks task, which also succeeds on my own machine..

Looks like it might have to run on a bigger machine huh? Weird that removing stuff from the bundle would cause it to use more memory though.

@tmeasday
Copy link
Member

tmeasday commented Nov 9, 2022

I'll take a look at the e2e tests

@tmeasday
Copy link
Member

@ndelangen I'm running this locally and it's failing the build task:

yarn task --task e2e-tests --start-from install --template cra/default-ts --no-link

image

@ndelangen
Copy link
Member Author

ndelangen commented Nov 10, 2022

I tried:

Looks like it might have to run on a bigger machine huh? Weird that removing stuff from the bundle would cause it to use more memory though.

But running in a bigger machine made no difference, I'll try even bigger.

I doubt it will help:
https://app.circleci.com/pipelines/github/storybookjs/storybook/31837/workflows/1102eec9-f6f3-4577-b1cd-a51c16cf6fff/jobs/439098/resources

...It doesn't look like the machine isn't running out of memory

@ndelangen
Copy link
Member Author

@tmeasday
When I run that command:

> yarn build-storybook --quiet
✅ install > ✅ compile > ✅ publish > 🔊 run-registry > ✅ sandbox > ✅ build > 🔊 serve > 🔄 e2e-tests


> yarn playwright test

Running 33 tests using 5 workers
  1) [chromium] › addon-controls.spec.ts:62:3 › addon-controls › should apply controls automatically when passed via url 

    page.goto: net::ERR_CONNECTION_RESET at http://localhost:8001/?path=/story/example-button--primary&args=label:Hello+world
    =========================== logs ===========================
    navigating to "http://localhost:8001/?path=/story/example-button--primary&args=label:Hello+world", waiting until "load"
    ============================================================

      61 |
      62 |   test('should apply controls automatically when passed via url', async ({ page }) => {
    > 63 |     await page.goto(`${storybookUrl}?path=/story/example-button--primary&args=label:Hello+world`);
         |                ^
      64 |
      65 |     const sbPage = new SbPage(page);
      66 |     await sbPage.waitUntilLoaded();

        at /Users/me/Projects/Storybook/core/code/e2e-tests/addon-controls.spec.ts:63:16

.circleci/config.yml Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit 3826bd3 into next Nov 11, 2022
@ndelangen ndelangen deleted the build/ts-up-addon-docs branch November 11, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants