Blocks: Do not copy code snippet when text inside preview is selected #19788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#18611 This patch introduces skip conditional for the "copy code snippet by shortcut key" feature. this condition would not work when the preview is iframe (user sets `docs: { inlineStories: false }`), but that does not matter as the event handler won't run in the first place.
ndelangen
approved these changes
Jan 13, 2023
JReinhold
approved these changes
Jan 14, 2023
JReinhold
deleted the
pocka/fix/18611-cannot-copy-docs-preview-content-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18611
What I did
Prevent the
<Preview/>component from copying code snippets when a user tries to copy texts inside the preview.I didn't change
onCopyCapturetoonCopydue to lacking context (code comment, commit message, or PR/issue comments). Therefore that event listener still interferes with anonCopyhandler inside the preview.(Which labels are suitable for this PR and the issue? There is no
blockslabel...)How to test
If your answer is yes to any of these, please make sure to include it in your PR.