Maintenance: Cancel workflow in CI on steps failure #19748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
This PR does a couple of things:
Merges the
publish
andbuild
steps into one. There's no reason to have them run separately, and this saves time (about 20 seconds).Adds a new command which is attached to the critical jobs:
[ check, lint, unit-tests, script-unit-tests ]
And if any of them failed, it will cancel the entire workflow. This way we don't spend unnecessary time running a bunch of sandbox/e2e tests in case the basic checks are failing, and they should be quickly fixed.
Here's an example when I forced a unit test failure:
Therefore, the entire run took less than 5 minutes instead of 20 minutes (including a bunch of unnecessary sandbox scripts that got executed)
How to test
If your answer is yes to any of these, please make sure to include it in your PR.