Dependencies: Bump prettier dependency, cleanup config #19672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
I'm doing a little cleanup of linting/prettier, and found a few issues:
.prettierrc
andprettier.config.js
. When running prettier via eslint, it seems thatprettier.config.js
was being used, but running on the command line (e.g. withyarn lint:other
), then.prettierrc
was used.dependencies
for prettier for a few packages, we were pinning to<=2.3.0
, due to IE support (Fix prettier transpile problems #17239).This is necessary, for prettier to be pre-bundled.@storybook/components
was setting prettier as a dev dependency, even though it is used as a direct dependency.What I did
yarn lint:other
now passes.I moved prettier toReverted this, needs to get pre-bundled.dependencies
of@storybook/components
.How to test
CI should pass